throw specific error when cannot parse Cypress arguments

[bahmutov]

• Closes Gitlab build fails with docker image cypress/included:3.8.3 #6279

User facing changelog

Cypress can silently fail to parse custom config string, or fail with a weird "cannot call split of undefined" error. This change catches config-parsing errors, prints an error message and the config string before exiting.

Example error message

Cypress encountered an error while parsing the argument config

You passed: xyz

The error was: Cannot read property 'split' of undefined

Same guard for parsing env and reporterOptions arguments.

PR Tasks

• Have tests been added/updated?
• Has the original issue been tagged with a release in ZenHub?

[cypress-bot]

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

• Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
• Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

• The feature/bugfix is self-documenting from within the product.
• The change provides the end user with a way to fix their problem (no dead ends).

Functionality

• The code works and performs its intended function with the correct logic.
• Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
• The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

• The code is readable (too many nested 'if's are a bad sign).
• Names used for variables, methods, etc, clearly describe their function.
• The code is easy to understood and there are relevant comments explaining.
• New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
• There are comments containing link(s) to the addressed issue (in tests and code).

Quality

• The change does not reimplement code.
• There's not a module from the ecosystem that should be used instead.
• There is no redundant or duplicate code.
• There are no irrelevant comments left in the code.
• Tests are testing the code’s intended functionality in the best way possible.

Internal

• The original issue has been tagged with a release in ZenHub.

[cypress]

---

Test summary

3615 • 0 • 47 • 0

---

Run details

Project	cypress
Status	Passed
Commit	40e30dc
Started	Feb 1, 2020 3:28 AM
Ended	Feb 1, 2020 3:33 AM
Duration	04:48 💡
OS	Linux Debian - 9.11
Browser	Multiple

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[bahmutov]

I have updated code to treat env, reporterOptions and config the same way and follow that error message

[bahmutov]

yeah, let me see if I can pull the old one and add to them, why `snap-shot-it` did not notice `.only` and trimmed old ones...

…

On Fri, Jan 31, 2020 at 4:47 PM Zach Bloomquist ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In packages/server/__snapshots__/cypress_spec.js <#6280 (comment)>: > @@ -1,52 +1,25 @@ -exports['RECORD_PARAMS_WITHOUT_RECORDING-ciBuildId 1'] = ` looks like the snapshots got reordered 😬 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6280?email_source=notifications&email_token=AAQ4BJQROHODSTK3FI7KPWLRASL65A5CNFSM4KN36O7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCT4AAJQ#pullrequestreview-351797286>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQ4BJX5NCE5IO434VLDGZDRASL65ANCNFSM4KN36O7A> .

-- Dr. Gleb Bahmutov, PhD Schedule video chat / phone call / meeting with me via https://calendly.com/bahmutov gleb.bahmutov@gmail.com @bahmutov <https://twitter.com/@bahmutov> https://glebbahmutov.com/ https://glebbahmutov.com/blog https://github.com/bahmutov

[bahmutov]

snapshots back to normal