Skip to content

Update GH actions: versions & npm publish config#3456

Merged
maxkfranz merged 2 commits intounstablefrom
feature/upgraded-gh-actions-vers
May 4, 2026
Merged

Update GH actions: versions & npm publish config#3456
maxkfranz merged 2 commits intounstablefrom
feature/upgraded-gh-actions-vers

Conversation

@maxkfranz
Copy link
Copy Markdown
Member

@maxkfranz maxkfranz commented Apr 29, 2026

Cross-references to related issues. If there is no existing issue that describes your bug or feature request, then create an issue before making your pull request.

Associated issues:

  • N/A / TODO

Notes re. the content of the pull request. Give context to reviewers or serve as a general record of the changes made. Add a screenshot or video to demonstrate your new feature, if possible.

  • The npm publish of 3.33.3 failed through the automated process.
  • The error logs seem opaque.
  • Possible issues:
    • The GH actions tools complain about using older versions, which use node@20. Apparently, v20 is not support by GHA.
    • There may be some minor config causing issues in the publish action, though the logs don't make this clear.
  • Remediations:
    • Updated the GH actions tools (e.g. actions/checkout) to the latest versions. The older versions are not supported by GH anymore.
    • Update our actions to use node@24, as specified in .nvmrc. It's all specified in one place now. Update .nvmrc and the actions will use that version.
    • Harden the publish action with:
      • An explicit env (in case it doesn't inherit the parent env properly)
      • Disable all npm caching options
      • Remove unneeded npm install step to simplify

Checklist

Author:

  • The proper base branch has been selected. New features go on unstable. Bug-fix patches can go on either unstable or master.
  • Automated tests have been included in this pull request, if possible, for the new feature(s) or bug fix. Check this box if tests are not pragmatically possible (e.g. rendering features could include screenshots or videos instead of automated tests).
  • The associated GitHub issues are included (above).
  • Notes have been included (above).
  • For new or updated API, the index.d.ts Typescript definition file has been appropriately updated.

Reviewers:

  • All automated checks are passing (green check next to latest commit).
  • At least one reviewer has signed off on the pull request.
  • For bug fixes: Just after this pull request is merged, it should be applied to both the master branch and the unstable branch. Normally, this just requires cherry-picking the corresponding merge commit from master to unstable -- or vice versa.

@maxkfranz maxkfranz requested a review from chrtannus April 29, 2026 20:50
@maxkfranz
Copy link
Copy Markdown
Member Author

FYI @mikekucera

@maxkfranz maxkfranz merged commit 38cad00 into unstable May 4, 2026
2 checks passed
maxkfranz added a commit that referenced this pull request May 4, 2026
…e/upgraded-gh-actions-vers

Update GH actions: versions & npm publish config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants