Skip to content

Inside labels#3457

Open
maxkfranz wants to merge 2 commits intounstablefrom
feature/inside-labels
Open

Inside labels#3457
maxkfranz wants to merge 2 commits intounstablefrom
feature/inside-labels

Conversation

@maxkfranz
Copy link
Copy Markdown
Member

Cross-references to related issues. If there is no existing issue that describes your bug or feature request, then create an issue before making your pull request.

Associated issues:

Notes re. the content of the pull request. Give context to reviewers or serve as a general record of the changes made. Add a screenshot or video to demonstrate your new feature, if possible.

  • Added left-inside / right-inside for text-halign
  • Added top-inside / bottom-inside for text-valign
  • Updated label projection, bounds, canvas drawing, texture offsets, and edge endpoint label intersection logic
  • Updated docs and TypeScript definitions
  • Added tests for style acceptance and label anchor math
  • Added inside label examples to docs demo

Checklist

Author:

  • The proper base branch has been selected. New features go on unstable. Bug-fix patches can go on either unstable or master.
  • Automated tests have been included in this pull request, if possible, for the new feature(s) or bug fix. Check this box if tests are not pragmatically possible (e.g. rendering features could include screenshots or videos instead of automated tests).
  • The associated GitHub issues are included (above).
  • Notes have been included (above).
  • For new or updated API, the index.d.ts Typescript definition file has been appropriately updated.

Reviewers:

  • All automated checks are passing (green check next to latest commit).
  • At least one reviewer has signed off on the pull request.
  • For bug fixes: Just after this pull request is merged, it should be applied to both the master branch and the unstable branch. Normally, this just requires cherry-picking the corresponding merge commit from master to unstable -- or vice versa.

maxkfranz added 2 commits May 4, 2026 13:29
- Added left-inside / right-inside for text-halign
- Added top-inside / bottom-inside for text-valign
- Updated label projection, bounds, canvas drawing, texture offsets, and edge endpoint label intersection logic
- Updated docs and TypeScript definitions
- Added tests for style acceptance and label anchor math

Ref: Inside-shape alignment of text labels #3443
Ref: Inside-shape alignment of text labels #3443
@maxkfranz maxkfranz requested a review from d2fong May 5, 2026 15:14
@maxkfranz maxkfranz linked an issue May 5, 2026 that may be closed by this pull request
4 tasks
@maxkfranz
Copy link
Copy Markdown
Member Author

@martinmolema, fyi. Try this branch out and let us know how it goes. You'll have to check it out and do a build.

@maxkfranz
Copy link
Copy Markdown
Member Author

@d2fong, would testing this in Cytoscape Web be the simplest way to validate this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inside-shape alignment of text labels

1 participant