Set scale for any coordinate transform#287
Conversation
ieivanov
left a comment
There was a problem hiding this comment.
This looks good to me, it's best if @talonchandler also takes a look before merging.
|
Also @edyoshikun you asked for the organelle box dataset. |
edyoshikun
left a comment
There was a problem hiding this comment.
The comments above are not a dealbreaker.
LGTM! Tested the CLI and the script after bumping my environment to 3.11
|
@ziw-liu I just saw your comments. this all LGTM! thanks |
talonchandler
left a comment
There was a problem hiding this comment.
Thanks for generalizing this @ziw-liu. I tested on a pyramid, and all is working as expected.
My only non-blocking suggestion is to consider renaming image to multiscale-level or similar. My understanding of the OME-Zarr spec is that they refer to the whole pyramid as an image, and they refer to each level of the pyramid as a multiscale-level. IMO this renaming would also make it easier to understand what this option is for.
Co-authored-by: Talon Chandler <talonchandler@gmail.com>
This argument name is consistent with |
Fix #278.
Position.set_scalenow works for any level, likePosition.set_transform.