Catch json decoding error from incomplete NDTIFF#298
Merged
Conversation
akila-14
reviewed
May 7, 2025
akila-14
left a comment
akila-14
left a comment
There was a problem hiding this comment.
✅ Looks good to me!
Very rarely, but iSIM acquisitions can end unexpectedly. The default iohub behavior was to quit on such datasets, so this fix is very helpful. The warning message is clear and informative, and it’s great that the rest of the processing can continue even when metadata is incomplete.
Tested on my end with a partially written dataset - works as expected.
Nice and clean fix - thanks, Ziwen!
akila-14
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows conversion of: