One _echo_finished and added TransformFunction Protocol#328
Draft
srivarra wants to merge 2 commits into
Draft
Conversation
ziw-liu
reviewed
Sep 8, 2025
Comment on lines
+179
to
+185
|
|
||
| Returns | ||
| ------- | ||
| NDArray | ||
| Transformed data with same shape as input. | ||
|
|
||
| Examples |
Contributor
There was a problem hiding this comment.
Not sure if I understand this. Are these examples of functions that are compatible with the protocols?
Contributor
There was a problem hiding this comment.
But these functions will throw an error when input_time_index is given as an argument.
Collaborator
Author
There was a problem hiding this comment.
Oh I see that now, what about something like this?
def gaussian_blur(data: NDArray, input_time_index: None | int, **kwargs) -> NDArray:
from skimage.filters import gaussian
if input_time_index:
data = data[input_time_index,...]
return gaussian(data, **kwargs)
Contributor
There was a problem hiding this comment.
You can test this by running it as a concrete parametrized test case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.