src layout and test warnings cleaned up#380
Merged
Merged
Conversation
…ross readers and tests Signed-off-by: Sricharan Reddy Varra <sricharan.varra@biohub.org>
Signed-off-by: Sricharan Reddy Varra <sricharan.varra@biohub.org>
edyoshikun
reviewed
Feb 28, 2026
edyoshikun
reviewed
Feb 28, 2026
Collaborator
edyoshikun
left a comment
edyoshikun
left a comment
There was a problem hiding this comment.
I think everything else looks good. As long as your tests pass then we are good to go. I had a minor comment . Thanks
edyoshikun
approved these changes
Feb 28, 2026
edyoshikun
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaned up a lot of the clutter from file open warnings:
print_info()to close all reader types, not just NGFFNodeMMStack.close()alongside the TiffFile_read_frame_metadata()(module="tifffile"never matched).close())_check_resultin converter tests to not access reader after conversion closes itSet license to reference the LICENSE file.