fix: rename zarr entry-point group for pyproject schema#405
Merged
Conversation
Use iohub.zarr_implementations instead of iohub.zarr-implementations. SchemaStore's pyproject.json only allows group names matching ^\w+(\.\w+)*$ (no hyphens in a segment), which tools like Taplo enforce; the previous name caused "Additional properties are not allowed" validation errors. Made-with: Cursor
Contributor
Author
|
@srivarra your call if you want this or now |
Contributor
Author
|
I'm not sure, I only caught it because by editor complained about its style, it would be the build still worked file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the
[project.entry-points]group fromiohub.zarr-implementationstoiohub.zarr_implementationsand updates the registry to match.Why
The SchemaStore pyproject.json only allows
entry-pointsgroup names matching^\w+(\.\w+)*$(dot-separated segments of word characters; hyphens are not allowed in a segment). Editors and tools that validatepyproject.tomlagainst that schema (e.g. Taplo) reported:Additional properties are not allowed ('iohub.zarr-implementations' was unexpected).Note
Breaking change for any external package that registered under the old group name. Update third-party
[project.entry-points."iohub.zarr-implementations"]toiohub.zarr_implementations.Made with Cursor