feat(tensorstore): expose recheck_cached_data on TensorStoreConfig#406
Merged
Conversation
Add ``recheck_cached_data`` to ``TensorStoreConfig`` and forward it into ``ts.open`` in ``TensorStoreImplementation.open_array``. The option controls whether cached chunk data is revalidated on every read (the TensorStore driver default) or only at open time (``"open"``), which is the recommended setting for long-running read-heavy workloads on networked filesystems (NFS/VAST) where revalidation costs one stat/GETATTR per chunk per read. ``None`` (default) preserves existing behaviour by omitting the kwarg so the TensorStore driver keeps its own default. ``True``, ``False``, and ``"open"`` are forwarded verbatim. Covered by a parametrized test that monkey-patches ``_ts_open`` to assert the kwarg reaches TensorStore for each configured value and is absent when unset. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
5 tasks
Collaborator
Author
|
@srivarra can we merge this to bump to 0.3.3 or alpha so we can pin on viscy? |
Collaborator
|
@edyoshikun yeah |
srivarra
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
rechecked_cached_dataand fowrad the kward into _ts_open in open_array, when it's explicitly set.