SecTrust object now is conditionally unwrapped#349
Merged
Conversation
Owner
|
Great work and thanks for fixing that issue! |
Author
|
Hey thanks for the quick approval. i see that this is included in 2.1.0, but somehow the spec hasn't been pushed to cocoa pods , because the latest available is still 2.0.4 (and if you try to target directly 2.1.0 you will get an error that the dependency can't be satisfied) Could you have a look? ah and btw, many thanks for the great library :) |
Owner
|
Finally got it done. Had a fair amount of trouble with CocoaPods & SPM working together. Anyway, 2.1.0 has been released! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue introduced by dbeb119#diff-b9ab27dc605d36ce558013387d2ba2d5
Now the SecTrust object is conditionally unwrapped and if not found , the pinning will fail*. I was never able to reproduce the scenario where the SecTrust object is null within a wss/https connection, i think this could be related to a failed SSL handshake (maybe due to networking issues) but these are just speculations at this point.
the client is clearly signalling is will for the pinning to be performed, so in absence of a trust that contains the certificates to be checked, i think it's better to reject the connection