Allow for arbitrary annotations in the pod template#419
Open
Calebjh wants to merge 1 commit intodanielqsj:masterfrom
Open
Allow for arbitrary annotations in the pod template#419Calebjh wants to merge 1 commit intodanielqsj:masterfrom
Calebjh wants to merge 1 commit intodanielqsj:masterfrom
Conversation
|
+1. This would be useful for us as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chart currently allows for arbitrary labels to be set in the deployment's pod spec, but only the specific datadog annotations to be set. This change will allow for arbitrary annotations to be configured via values.
This use-case is relevant for me because my company's Prometheus setup discovers scrape targets via Annotation, not via ServiceMonitor.