Merged
Conversation
This fixes a security vulnerability in FileReceiver. Some classes which inherit from FileReceiver construct the filenames by taking a filename which is transmitted over the air. The filename was not sanitized to check that it does not contain path components such as ../. Therefore, a crafted filename could cause accesses outside of self._path. This fixes the problem by checking that the filename has no path components, and replacing it by a UUID and logging a message if it contains path components. This fixes #803.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a security vulnerability in
FileReceiver. Some classes which inherit fromFileReceiverconstruct the filenames by taking a filename which is transmitted over the air. The filename was not sanitized to check that it does not contain path components such as../. Therefore, a crafted filename could cause accesses outside ofself._path.This fixes the problem by checking that the filename has no path components, and replacing it by a UUID and logging a message if it contains path components.
This fixes #803.