`dapp test` sets `msg.sender == 0` which is bad for testing eth or token transfers

[mbrock]

Issue by retotrinkler
Sunday Jun 10, 2018 at 10:43 GMT
Originally opened as dapphub/dapp#91

---

Example Solidity

        // Transfer to owner
        owner.transfer(amount);

where owner == msg.sender, dapp test sets msg.sender == 0 which then results in a failing test:

     │  ├╴call HtlcTest::[fallback function](0x) (src/Htlc.sol:61)
      │  │  └╴error Revert (src/Htlc.t.sol:6)
      │  └╴error Revert <source not found>
      └╴error Revert <source not found>

0.transfer(amount) seems to trigger fallback function; to have a non-zero default for msg.sender could help

[rainbreak]

I think this is actually resulting from an undefined fallback function on the test contract.