Skip to content

Propagates UseJsonSerialization setting#1648

Merged
WhitWaldo merged 10 commits into
dapr:masterfrom
ZeBobo5:fix/missing-propery-propagation
Feb 23, 2026
Merged

Propagates UseJsonSerialization setting#1648
WhitWaldo merged 10 commits into
dapr:masterfrom
ZeBobo5:fix/missing-propery-propagation

Conversation

@ZeBobo5

@ZeBobo5 ZeBobo5 commented Oct 26, 2025

Copy link
Copy Markdown
Contributor

Fixes #1647

Expected Behavior

The UseJsonSerialization option should be correctly passed to the ActorRuntimeOptions configuration so that JSON serialization is properly used when configured.

Actual Behavior

The line

UseJsonSerialization = options.UseJsonSerialization

is missing in the code block inside [ActorsServiceCollectionExtensions.cs](https://github.com/dapr/dotnet-sdk/blob/274eb529b11d36d490070530afff49d774fe0bb4/src/Dapr.Actors.AspNetCore/ActorsServiceCollectionExtensions.cs#L62).
As a result, JSON deserialization may not work as expected.

Steps to Reproduce the Problem

  1. Configure an actor with UseJsonSerialization = true.
  2. Run the application.
  3. Observe that JSON serialization settings are not applied, because the option is never propagated.

Release Note

RELEASE NOTE: FIX Missing propagation of UseJsonSerialization option in ActorsServiceCollectionExtensions.

@ZeBobo5 ZeBobo5 requested review from a team as code owners October 26, 2025 03:12
@ZeBobo5 ZeBobo5 force-pushed the fix/missing-propery-propagation branch from cea3d32 to 6c55ba9 Compare October 26, 2025 03:16
Ensures the UseJsonSerialization option is correctly passed through when configuring actor runtime settings, maintaining consistent serialization behavior.

Signed-off-by: Laurent BOHEAS <gitkraken@m3scalinum.dev>
Signed-off-by: ZeBobo5 <zebobo5@hotmail.com>
@ZeBobo5 ZeBobo5 force-pushed the fix/missing-propery-propagation branch from 6c55ba9 to ea3a795 Compare October 26, 2025 03:29
@WhitWaldo WhitWaldo added this to the v1.17 milestone Oct 27, 2025
@marcduiker

Copy link
Copy Markdown
Contributor

@holopin-bot @ZeBobo5 sdk-badge Thank you! Here's a digital badge as a small token of appreciation.

@holopin-bot

holopin-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown

Congratulations @ZeBobo5, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cmqbf6iqu000jjl04tqu4q71k

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing propagation of UseJsonSerialization option in ActorsServiceCollectionExtensions

3 participants