Skip to content

Refactoring serializer from Dapr.Workflow to Dapr.Common#1805

Merged
WhitWaldo merged 2 commits into
masterfrom
common-serializer
May 3, 2026
Merged

Refactoring serializer from Dapr.Workflow to Dapr.Common#1805
WhitWaldo merged 2 commits into
masterfrom
common-serializer

Conversation

@WhitWaldo

Copy link
Copy Markdown
Contributor

Description

Migrating serializer from workflow into Dapr.Common so it can be used more widely. While the migration was made internally to use the serializer in Dapr.Common, changes were made to ensure this isn't a breaking change (for now, but I also added an obsolete flag to make it clear it will be a breaking change alongside the release of Dapr runtime v1.20).

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

… more widely

Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
@WhitWaldo WhitWaldo self-assigned this May 3, 2026
@WhitWaldo WhitWaldo requested review from a team as code owners May 3, 2026 11:13
@WhitWaldo WhitWaldo added kind/enhancement New feature or request area/client labels May 3, 2026
@codecov

codecov Bot commented May 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.42%. Comparing base (0a41199) to head (acc9b65).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...rc/Dapr.Common/Serialization/JsonDaprSerializer.cs 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1805      +/-   ##
==========================================
- Coverage   65.54%   65.42%   -0.13%     
==========================================
  Files         295      296       +1     
  Lines        8678     8694      +16     
  Branches     1004     1009       +5     
==========================================
  Hits         5688     5688              
- Misses       2745     2761      +16     
  Partials      245      245              
Flag Coverage Δ
net10.0 65.41% <0.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/client kind/enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants