Bugfix: Correctly apply patch inserted before current replay target#1807
Closed
WhitWaldo wants to merge 2 commits into
Closed
Bugfix: Correctly apply patch inserted before current replay target#1807WhitWaldo wants to merge 2 commits into
WhitWaldo wants to merge 2 commits into
Conversation
…re timer (and incorrectly resulting in failure state) Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1807 +/- ##
=======================================
Coverage 65.42% 65.42%
=======================================
Files 296 296
Lines 8694 8694
Branches 1009 1009
=======================================
Hits 5688 5688
Misses 2761 2761
Partials 245 245
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ned a listener for `Dapr.Workflow` which showed this as working. By default, .NET returns null silently if there's no activity listener registered for a source meaning the bug persisted when a listener wasn't explicitly registered. Fixed this and added another regression test. Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
This was referenced Jun 11, 2026
This was referenced Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Applying patch for reported bug regarding the insertion of patch before timer (and incorrectly resulting in failure state).
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: