Skip to content

Bugfix: Addressing OpenTelemetry propagation bug#1808

Merged
WhitWaldo merged 3 commits into
masterfrom
observability-fix
May 9, 2026
Merged

Bugfix: Addressing OpenTelemetry propagation bug#1808
WhitWaldo merged 3 commits into
masterfrom
observability-fix

Conversation

@WhitWaldo

Copy link
Copy Markdown
Contributor

Description

Another fix for reported OpenTelemetry issue. The test in #1795 assigned a listener for Dapr.Workflow which showed this as working. By default, .NET returns null silently if there's no activity listener registered for a source meaning the bug persisted when a listener wasn't explicitly registered. Fixed this and added another regression test.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1749

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

…ned a listener for `Dapr.Workflow` which showed this as working. By default, .NET returns null silently if there's no activity listener registered for a source meaning the bug persisted when a listener wasn't explicitly registered. Fixed this and added another regression test.

Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
@WhitWaldo WhitWaldo added this to the v1.18 milestone May 9, 2026
@WhitWaldo WhitWaldo self-assigned this May 9, 2026
@WhitWaldo WhitWaldo requested review from a team as code owners May 9, 2026 02:30
@codecov

codecov Bot commented May 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.42%. Comparing base (85f94fa) to head (26b3595).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1808   +/-   ##
=======================================
  Coverage   65.42%   65.42%           
=======================================
  Files         296      296           
  Lines        8694     8694           
  Branches     1009     1009           
=======================================
  Hits         5688     5688           
  Misses       2761     2761           
  Partials      245      245           
Flag Coverage Δ
net10.0 65.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@WhitWaldo WhitWaldo merged commit 3516729 into master May 9, 2026
440 of 445 checks passed
@WhitWaldo WhitWaldo deleted the observability-fix branch May 9, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trace propagation breaks in downstream calls made from Dapr.Workflow user activities

1 participant