bugfix(workflows): Addressing "no such instance exists" errors#1812
Merged
Conversation
… "no such instance exists" messages Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1812 +/- ##
=======================================
Coverage 65.42% 65.42%
=======================================
Files 296 296
Lines 8694 8694
Branches 1009 1009
=======================================
Hits 5688 5688
Misses 2761 2761
Partials 245 245
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Jun 11, 2026
This was referenced Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
ProcessActivityAsyncmethod had a single try/catch method that wrapped both the handler execution and gRPC delivery calls. When an activity completed successfully, butCompleteActivityTaskAsyncthrew (transiently), the trigger here beingno such instance existsfrom the sidecar, theRpcExceptionwas caught by the outer handler which treated it as an activity failure and made a secondCompleteActivityTaskAsynccall with the error message from that exception. The sidecar accepted this second call and recorded aTaskFailedhistory event, so on the next replay,HandleFailedActivityFromHistoryfound this event and threw aWorkflowTaskFailedExceptionwith the unknown status code and this detail propagating a transient transport error as a permanent business-logic failure.This simply splits the single try/catch block into two separate blocks:
This means no second
Complete*Asynccall is ever made when delivery fails and no spuriousTaskFailedevents are written to history.Added unit tests to validate.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: