Automatic registration of workflows and activities#1823
Conversation
…nerator to apply whether user opts into named versioning at all and extends existing automatic registration of workflows to activities as well. Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1823 +/- ##
==========================================
+ Coverage 63.46% 63.47% +0.01%
==========================================
Files 312 312
Lines 9279 9279
Branches 1101 1101
==========================================
+ Hits 5889 5890 +1
Misses 3130 3130
+ Partials 260 259 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@copilot I'm seeing some build errors due to visibility level. Could you please fix each of those errors? |
Agent-Logs-Url: https://github.com/dapr/dotnet-sdk/sessions/81b3dd1d-a1b1-44be-bab7-e3160d88fb5c Co-authored-by: WhitWaldo <2238529+WhitWaldo@users.noreply.github.com>
Fixed in commit I updated the source generator to skip inaccessible activity types during auto-discovery, which resolves the visibility-level build errors you reported. No UI changes in this PR, so there is no UI screenshot to share. |
|
@copilot The first run showed all the Dapr.Workflow.Versioning integration tests failing. Can you please fix them? |
…kflows Agent-Logs-Url: https://github.com/dapr/dotnet-sdk/sessions/73296700-a9a8-4541-8625-ce30d4b37589 Co-authored-by: WhitWaldo <2238529+WhitWaldo@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dapr/dotnet-sdk/sessions/73296700-a9a8-4541-8625-ce30d4b37589 Co-authored-by: WhitWaldo <2238529+WhitWaldo@users.noreply.github.com>
Fixed in commit I updated the failing versioning integration test to match the new automatic registration behavior (including activity auto-registration) and adjusted the test activity visibility so generator-based registration works correctly. No UI changes in this PR, so there is no UI screenshot to provide. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Description
Implementing changes to the merged
Dapr.Workflow.Versioningsource generator to apply whether user opts into named versioning at all and extends existing automatic registration of workflows to activities as well.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: