Skip to content

Automatic registration of workflows and activities#1823

Merged
WhitWaldo merged 4 commits into
masterfrom
automatic-workflow-registration
May 20, 2026
Merged

Automatic registration of workflows and activities#1823
WhitWaldo merged 4 commits into
masterfrom
automatic-workflow-registration

Conversation

@WhitWaldo

Copy link
Copy Markdown
Contributor

Description

Implementing changes to the merged Dapr.Workflow.Versioning source generator to apply whether user opts into named versioning at all and extends existing automatic registration of workflows to activities as well.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

…nerator to apply whether user opts into named versioning at all and extends existing automatic registration of workflows to activities as well.

Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
@WhitWaldo WhitWaldo added this to the v1.18 milestone May 20, 2026
@WhitWaldo WhitWaldo self-assigned this May 20, 2026
@WhitWaldo WhitWaldo requested review from a team as code owners May 20, 2026 09:45
@codecov

codecov Bot commented May 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.47%. Comparing base (62138bf) to head (dbbcea5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1823      +/-   ##
==========================================
+ Coverage   63.46%   63.47%   +0.01%     
==========================================
  Files         312      312              
  Lines        9279     9279              
  Branches     1101     1101              
==========================================
+ Hits         5889     5890       +1     
  Misses       3130     3130              
+ Partials      260      259       -1     
Flag Coverage Δ
net10.0 63.46% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@WhitWaldo

Copy link
Copy Markdown
Contributor Author

@copilot I'm seeing some build errors due to visibility level. Could you please fix each of those errors?

Copilot AI commented May 20, 2026

Copy link
Copy Markdown
Contributor

@copilot I'm seeing some build errors due to visibility level. Could you please fix each of those errors?

Fixed in commit 03ec07c.

I updated the source generator to skip inaccessible activity types during auto-discovery, which resolves the visibility-level build errors you reported.

No UI changes in this PR, so there is no UI screenshot to share.

@WhitWaldo

Copy link
Copy Markdown
Contributor Author

@copilot The first run showed all the Dapr.Workflow.Versioning integration tests failing. Can you please fix them?

Copilot AI commented May 20, 2026

Copy link
Copy Markdown
Contributor

@copilot The first run showed all the Dapr.Workflow.Versioning integration tests failing. Can you please fix them?

Fixed in commit dbbcea5.

I updated the failing versioning integration test to match the new automatic registration behavior (including activity auto-registration) and adjusted the test activity visibility so generator-based registration works correctly.

No UI changes in this PR, so there is no UI screenshot to provide.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • 172.19.0.1
    • Triggering command: REDACTED, pid is -1 (packet block)
  • 172.20.0.1
    • Triggering command: REDACTED, pid is -1 (packet block)
  • 172.21.0.1
    • Triggering command: REDACTED, pid is -1 (packet block)
  • 172.22.0.1
    • Triggering command: REDACTED, pid is -1 (packet block)
  • 172.23.0.1
    • Triggering command: REDACTED, pid is -1 (packet block)
  • 172.24.0.1
    • Triggering command: REDACTED, pid is -1 (packet block)
  • 172.25.0.1
    • Triggering command: REDACTED, pid is -1 (packet block)
  • 172.26.0.1
    • Triggering command: REDACTED, pid is -1 (packet block)
  • 172.27.0.1
    • Triggering command: REDACTED, pid is -1 (packet block)
  • 172.28.0.1
    • Triggering command: REDACTED, pid is -1 (packet block)
  • 172.29.0.1
    • Triggering command: REDACTED, pid is -1 (packet block)
  • 224.0.0.251
    • Triggering command: REDACTED, pid is -1 (packet block)

If you need me to access, download, or install something from one of these locations, you can either:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants