Skip to content

Fix workflow trace correlation#1829

Merged
WhitWaldo merged 2 commits into
dapr:masterfrom
mtaghavi2005:fix-workflow-trace-correlation
May 26, 2026
Merged

Fix workflow trace correlation#1829
WhitWaldo merged 2 commits into
dapr:masterfrom
mtaghavi2005:fix-workflow-trace-correlation

Conversation

@mtaghavi2005

Copy link
Copy Markdown
Contributor

Description

Fix workflow trace correlation in the workflow worker so workflow/activity logs keep the expected trace context.

  • Keep trace context for:
    • activity failure logs
    • activity CompleteActivityTaskAsync
    • workflow replay-safe logs
    • workflow completion logs
  • Set ActivityStatusCode.Error for failed activities

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1819

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Mohammad Taghavi <mtaghavi2005@gmail.com>
Signed-off-by: Mohammad Taghavi <mtaghavi2005@gmail.com>

@WhitWaldo WhitWaldo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - waiting for E2E tests to finish running/pass and I'll get this in for the next release. I appreciate you taking the time to file the issue and put this together.

@WhitWaldo WhitWaldo merged commit 7f1c553 into dapr:master May 26, 2026
885 of 891 checks passed
@marcduiker

Copy link
Copy Markdown
Contributor

@holopin-bot @mtaghavi2005 sdk-badge Thank you! Here's a digital badge as a small token of appreciation.

@holopin-bot

holopin-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown

Congratulations @mtaghavi2005, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cmqbf64hj0008jy044rbs19vk

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Activity failure, workflow worker, and replay-safe logs lose trace correlation

3 participants