Skip to content

No longer logging connection closed exception when app closes#1841

Merged
WhitWaldo merged 1 commit into
masterfrom
wf-op-cancelled
Jun 2, 2026
Merged

No longer logging connection closed exception when app closes#1841
WhitWaldo merged 1 commit into
masterfrom
wf-op-cancelled

Conversation

@WhitWaldo

Copy link
Copy Markdown
Contributor

Description

No longer passing exception when workflow is shut down per cancellation request. As explained in the linked issue, cancellation is requested when there's an intentional effort to close the connection, not because of something unintended, so it follows that an exception shouldn't be logged on such an intentional behavior. The case was made and I agree.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1837

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

…on request

Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
@WhitWaldo WhitWaldo added this to the v1.18 milestone Jun 2, 2026
@WhitWaldo WhitWaldo self-assigned this Jun 2, 2026
@WhitWaldo WhitWaldo requested review from a team as code owners June 2, 2026 19:41
@WhitWaldo WhitWaldo added kind/bug Something isn't working area/workflow labels Jun 2, 2026
@codecov

codecov Bot commented Jun 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.46%. Comparing base (c63d7a4) to head (8fff630).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1841   +/-   ##
=======================================
  Coverage   63.46%   63.46%           
=======================================
  Files         312      312           
  Lines        9279     9279           
  Branches     1101     1101           
=======================================
  Hits         5889     5889           
- Misses       3129     3130    +1     
+ Partials      261      260    -1     
Flag Coverage Δ
net10.0 63.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/workflow kind/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OperationCanceledException when application is exiting

1 participant