Use server-blocking WaitForInstnace* RPCs instead of client polling#1843
Merged
Conversation
…lient polling WaitForWorkflowStartAsync and WaitForWorkflowCompletionAsync polled GetInstance on a fixed 500ms/1s cadence. The sidecar already exposes server-blocking WaitForInstanceStart / WaitForInstanceCompletion RPCs that return the moment the instance reaches the target state, and the go-sdk (via durabletask-go) already uses them. This switches both methods to the blocking RPCs, wrapped in an exponential-backoff retry that re-issues on transient interruptions (DeadlineExceeded / Unavailable) and propagates cancellation, mirroring durabletask-go's client. Calls continue to flow through CreateCallOptions so the dapr-api-token is honored. Removes the now-dead client-poll tests and adds coverage for the blocking RPC path, transient-error retry, non-transient propagation, and cancellation. Fixes #1838 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Paul Stadler <paul.stadler@meshconnect.com>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
4 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1843 +/- ##
=======================================
Coverage 63.46% 63.46%
=======================================
Files 312 312
Lines 9279 9279
Branches 1101 1101
=======================================
Hits 5889 5889
Misses 3130 3130
Partials 260 260
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Jun 11, 2026
This was referenced Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Continuation of the work at #1839
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1838
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: