Skip to content

FIx for Dapr.Common not being transiently referenced by project#1852

Merged
WhitWaldo merged 9 commits into
masterfrom
dapr-common-transitive-install
Jun 15, 2026
Merged

FIx for Dapr.Common not being transiently referenced by project#1852
WhitWaldo merged 9 commits into
masterfrom
dapr-common-transitive-install

Conversation

@WhitWaldo

Copy link
Copy Markdown
Contributor

Description

After installing the Dapr.SecretsManagement package, the developer will be prompted to install the Dapr.Common package as well. This should be transitively referenced and not require the developer to have to explicitly install it separately. This patch fixes this.

Also adding testing with an aim to prevent regressions around this issue in the future with this and other packages in the solution.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
@WhitWaldo WhitWaldo self-assigned this Jun 14, 2026
@WhitWaldo WhitWaldo requested review from a team as code owners June 14, 2026 18:54
@codecov

codecov Bot commented Jun 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.18%. Comparing base (9608f85) to head (29eae9f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1852      +/-   ##
==========================================
- Coverage   63.19%   63.18%   -0.02%     
==========================================
  Files         330      330              
  Lines        9534     9534              
  Branches     1110     1110              
==========================================
- Hits         6025     6024       -1     
  Misses       3198     3198              
- Partials      311      312       +1     
Flag Coverage Δ
net10.0 63.14% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…ing correctly to prevent ongoing regressions as I pack more projects in this way

Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant