Migrate from remote driver to docker-container driver#23
Closed
Migrate from remote driver to docker-container driver#23
Conversation
Replace the remote driver (via docker compose) with the docker-container driver, which embeds the buildcage image directly as a BuildKit builder.
Replace docker-compose based container management with `docker buildx create --driver docker-container` in setup/report actions. Remove compose.yml, simplify post cleanup, and update README examples to reflect the new two-step workflow.
The docker-container driver overrides CMD so the --addr flag in the Dockerfile was dead code. With no TCP listener, the iptables rules blocking port 1234 from buildkit0 are also unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
remotedriver had several limitations:The
docker-containerdriver resolves all of these:docker buildx createhandles container lifecycle, with built-in cleanup viadocker buildx rmChanges
s6-rc(compile-time service graph) withs6-svscan(runtime supervision) and add a custom entrypoint.sh` for init scripts + service startupcompose.yml,setup/compose.yml, andcompose.test.ymlnetwork/volume definitions that were only needed for the remote driversetup/main.mjsto calldocker buildx createdirectly with driver-opts instead ofdocker-compose upreport/main.mjsto usedocker execon the buildkit container instead of relying on compose service namestest.ymlto use./setupand./reportactions directly, serving as E2E tests for the actions themselves