Fix FileOrder not being applied correctly between plugin and data files#31
Closed
maxijonson wants to merge 1 commit into
Closed
Fix FileOrder not being applied correctly between plugin and data files#31maxijonson wants to merge 1 commit into
maxijonson wants to merge 1 commit into
Conversation
Owner
|
Thanks for your work on this. Merged your changes manually in the 1.0.15 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files are correctly ordered with the
FileOrderdirective inMergeHandler. However, they are being split into three categories of files in theFileCreator:_pluginFiles,_dataFilesand_frameworks. These category of files are then written in separate loops, breaking the original order specified.In
PluginModeandFrameworkMode, plugin and data files are always written together in the same class. However, since they run in different loops, the order originally specified is broken.To fix this, when in
PluginModeorFrameworkMode, I write plugin and data files together, in theOrderthey are specified.Fixes #30