Add support for insert CSV#1067
Merged
dimitri-yatsenko merged 5 commits intodatajoint:masterfrom Dec 16, 2022
Merged
Conversation
Member
|
Looks great! Thanks! Please update the CHANGELOG and we'll merge. |
Member
dimitri-yatsenko
left a comment
dimitri-yatsenko
left a comment
There was a problem hiding this comment.
Would it make sense to also accept the filepath in the form of a str as well as pathlib.Path?
Contributor
Author
Updated
My thought process was that a pathlib object is unambiguous. But I can adjust if you prefer accepting filepaths as strings. Is there any case where we would want to accept data as a string? |
dimitri-yatsenko
approved these changes
Dec 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
insertmethod, check if object is pathlib.Path. If so, load as comma-delimited data