When retrieving data from S3, account for chunking#1085
Merged
dimitri-yatsenko merged 5 commits intodatajoint:masterfrom May 15, 2023
Merged
When retrieving data from S3, account for chunking#1085dimitri-yatsenko merged 5 commits intodatajoint:masterfrom
dimitri-yatsenko merged 5 commits intodatajoint:masterfrom
Conversation
dimitri-yatsenko
approved these changes
May 12, 2023
Contributor
Author
|
This PR changes the |
Member
pull from upstream and update changelog
Contributor
Author
|
Done! |
dimitri-yatsenko
approved these changes
May 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seems to be an issue with retrieval of larger ("external") files from S3 compatible buckets. I documented the error here: #1083. I brought it up as issue in the minio-api repository as well: minio/minio-py#1280.
The problem is that files can be returned as chunks via the minio API, such that
.datacannot be called directly. Instead,.streamand subsequent concatenation of bytes seems to work for all cases. This behavior is already correctly implemented infget()(datajoint-python/datajoint/s3.py
Line 88 in ee95f02