Use npm@6.11 in CircleCI config to fix broken build from git dependencies#222
Use npm@6.11 in CircleCI config to fix broken build from git dependencies#222
Conversation
|
@lehnerchristian and @dg-datavisyn Could you please run |
|
I use node@8.15.0 and npm@6.4.1 |
|
but I'll update npm locally |
|
After testing the different npm versions it seems that npm@6.6.0 is working. Looking at the release notes it contains a fix that handles git branch references correctly. |
|
Following the release notes npm@6.9.0 solves git dependencies with #semver: don’t seem to resolve and dedup correctly, which might be relevant for us since we are using semver ranges in for git branches.
|
|
We (@anita-steiner, @dg-datavisyn, and @lehnerchristian) agreed in a personal meeting that we will test and update to Node 12 LTS (see phovea/generator-phovea#191), which includes npm@6.11. |
|
The next generator release uses Node.js v12. After updating the CircleCI config to the new version, we this issue should be fixed. |
# Conflicts: # package-lock.json # package.json
Use the config template from generator-phovea v2.0.1
|
Close this PR and open a new (clean) PR instead. See PR #255. |
Fixes #221.
Related PR https://github.com/datavisyn/dTiles/pull/210
Summary
Next steps
caleydo/phovea_circleci_python:v2.0installsnode 8.x, which resolves to node@8.14.0 and npm@6.4.1caleydo/phovea_circleci_python:v3.0caleydo/phovea_circleci_python:v3.0