Fix:修复13章旅行助手代码因为自动扩展字段失效,无法利用amap工具的问题#493
Merged
jjyaoao merged 1 commit intodatawhalechina:mainfrom Apr 15, 2026
Merged
Conversation
Collaborator
|
感谢,LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.ToolRegistry 判断工具是否需要展开时,需要auto_expand 、hasattr(tool, 'expandable') 、tool.expandable 三个条件都同时满足
2.MCPTool 初始化时虽然有 auto_expand=true ,但没有把父类 Tool 的 expandable 属性设为真,导致 tool.expandable 仍是父类 Tool 中设置的默认值 false,从而使得 ToolRegistry 永远不会执行展开的代码逻辑
3.最终导致了高德的 MCP 工具无法正常使用
如果要正常使用高德 MCP 工具,还需要手动指定 self.amap_tool.expandable=True