fix: add America/St_Johns handling to tzOffset#7
Merged
kossnocorp merged 2 commits intodate-fns:mainfrom Sep 21, 2024
allohamora:bugfix/wrong-time-offset
Merged
fix: add America/St_Johns handling to tzOffset#7kossnocorp merged 2 commits intodate-fns:mainfrom allohamora:bugfix/wrong-time-offset
kossnocorp merged 2 commits intodate-fns:mainfrom
allohamora:bugfix/wrong-time-offset
Conversation
- Made tests less specific - Added tests for positive fractional time zones - The trick with assigning NaN cut few bytes from the function 219 B -> 214 B
Member
|
@allohamora thank you so much for the bugfix. 9 years working on the library, and I never heard that there's a negative fractional time zone 🫠 I added more tests, made them less specific, and cut a few bytes with the default I will ship a new release as soon as possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes incorrect America/St_Johns handling in tzOffset and refactors some code.
Before:
After:
