update login

[dbarzin]

Summary by CodeRabbit

• New Features

  • LDAP login supports matching across multiple attributes and optional base DN restriction.
  • Automatic local account provisioning from LDAP when enabled; assigns a default email if missing and an Auditee role.
  • User management: Title is now optional; role must be between 1 and 5; updates may omit title and role.

• Chores

  • Configuration rename: LDAP_LOGIN_ATTRIBUTE → LDAP_LOGIN_ATTRIBUTES (same comma-separated format).

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Renamed LDAP login config key in .env.example. Updated LoginController to support optional base DN restriction, multi-attribute LDAP search, debug logging, and adjusted auto-provisioning defaults (email fallback, role assignment). Modified UserController validation: title now nullable; role constrained 1–5, required on create, optional on update.

Changes

Cohort / File(s)	Summary
Config key rename /.env.example	Renamed LDAP_LOGIN_ATTRIBUTE to LDAP_LOGIN_ATTRIBUTES with the same comma-separated values.
Auth LDAP lookup & provisioning /app/Http/Controllers/Auth/LoginController.php	Added optional base DN scoping; switched to app.ldap_login_attributes; implemented OR-based multi-attribute search; added debug logs; on auto-provision, default email to user@localhost.local and set role=5.
User validation adjustments /app/Http/Controllers/UserController.php	store(): title nullable; role required with min:1,max:5. update(): title nullable; role optional with min:1,max:5 when provided.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant U as User
  participant App as App (LoginController)
  participant LDAP as LDAP Server
  participant DB as Local DB

  U->>App: Submit username/password
  App->>LDAP: Bind (service account) or pass-through
  alt LDAP bind ok
    App->>LDAP: Search user<br/>in(Base DN if configured)<br/>OR-match(login attributes)
    LDAP-->>App: User entry or none
    alt User found
      App->>DB: Find local user by username/email
      alt Local user exists
        App-->>U: Auth success
      else No local user
        App->>DB: Create user (email fallback, role=5)
        App-->>U: Auth success
      end
    else No LDAP user
      App-->>U: Auth failure (not found)
    end
  else Bind failed
    App-->>U: Auth failure (bind error)
  end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

A rabbit taps the LDAP tree, hop-hop-hop—
Finds you by many names, it won’t stop.
Through base DNs and leafy OUs it peers,
Creates a cozy user burrow, no fears.
Titles optional, roles aligned just right—
Login moonlit, provisioning bright. 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 4421385 and ff04940.

📒 Files selected for processing (3)

• .env.example (1 hunks)
• app/Http/Controllers/Auth/LoginController.php (3 hunks)
• app/Http/Controllers/UserController.php (2 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch dev

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.