fix accept once task

[dbarzin]

Summary by CodeRabbit

• Bug Fixes
  • Control acceptance process now correctly distinguishes between periodic and non-periodic controls, preventing unnecessary duplication and ensuring proper status updates for both types.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 7803d29 and 1c9555f.

📒 Files selected for processing (1)

• app/Http/Controllers/ControlController.php

---

Walkthrough

The accept() method in ControlController now conditionally executes control replication and next_id linking based on periodicity; replication only occurs when periodicity is not 0, otherwise the control status is updated directly.

Changes

Cohort / File(s)	Summary
Conditional Control Replication app/Http/Controllers/ControlController.php	Wrapped control replication, field reset, and next_id linking logic in a conditional block that executes only when periodicity is not 0. When periodicity equals 0, replication is skipped and status is set directly.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

A rabbit hops through periodic affairs,
When periodicity dances with careful cares! 🐰
But zero brings wisdom—a conditional way,
Skip the replication, just update today! ✨

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch dev

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}