Dev

[dbarzin]

Summary by CodeRabbit

• New Features

  • Indicator field is now editable as a textarea in the control editor interface.

• Chores

  • Removed app version entry from environment configuration template.
  • Standardized configuration naming in social authentication settings.

[coderabbitai]

Walkthrough

This PR removes APP_VERSION from .env.example, adds indicator field persistence in ControlController, updates OAuth configuration key casing in SocialiteController, and converts the control indicator field from read-only display to an editable textarea input.

Changes

Cohort / File(s)	Summary
Environment Configuration .env.example	Removed APP_VERSION environment variable declaration from the example template.
Control Indicator Field app/Http/Controllers/ControlController.php, resources/views/controls/edit.blade.php	Added indicator field assignment in control save method and converted the view from read-only <pre> block to editable <textarea> with validation-aware fallback logic.
Socialite Provider Configuration app/Http/Controllers/SocialiteController.php	Updated configuration key casing from allow_create_User / allow_update_User to lowercase allow_create_user / allow_update_user in OAuth callback handler.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Whiskers twitch at changes neat,
Field indicators now concrete,
From read-only to edit's grace,
Configuration finds its place! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title 'Dev' is overly vague and generic, failing to describe the specific changes made across multiple files in the pull request.	Replace with a descriptive title that summarizes the main change, such as 'Add indicator field editing support and fix configuration key casing' or similar.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch dev

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

app/Http/Controllers/ControlController.php (1)

1569-1569: Consider adding indicator to the $fillable array in the Control model for consistency.

The indicator field is assigned directly in the save() method (line 1569), but it's not listed in the model's $fillable array. While direct property assignment works fine, several fields used in this method—scope, note, indicator, score, status, and next_id—are missing from $fillable. Adding these to the array would ensure consistency and enable the use of mass assignment patterns in the future.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@app/Http/Controllers/ControlController.php` at line 1569, The Control model's
$fillable array should include fields assigned in ControlController@save (such
as indicator) to allow mass assignment and maintain consistency; update the
Control model's $fillable property to add 'indicator' and also add the other
currently-assigned fields used in that method ('scope', 'note', 'score',
'status', 'next_id') so future mass-assignment (e.g., Control::create($data) or
$model->fill($data)) works safely and consistently.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@app/Http/Controllers/ControlController.php`:
- Line 1569: The Control model's $fillable array should include fields assigned
in ControlController@save (such as indicator) to allow mass assignment and
maintain consistency; update the Control model's $fillable property to add
'indicator' and also add the other currently-assigned fields used in that method
('scope', 'note', 'score', 'status', 'next_id') so future mass-assignment (e.g.,
Control::create($data) or $model->fill($data)) works safely and consistently.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: c5f093ba-b4be-4649-a2b1-a3ee36cd13ab

📥 Commits

Reviewing files that changed from the base of the PR and between 1df558b and 35c9762.

📒 Files selected for processing (4)

• .env.example
• app/Http/Controllers/ControlController.php
• app/Http/Controllers/SocialiteController.php
• resources/views/controls/edit.blade.php

💤 Files with no reviewable changes (1)

• .env.example