fix: allow the client to work in either websocket environment#199
Merged
lukeocodes merged 1 commit intoNov 15, 2023
Merged
Conversation
davidvonthenen
approved these changes
Nov 15, 2023
lukeocodes
deleted the
lo/197-cloudflare-worker-compatibility-issue-with-liveclient
branch
lukeocodes
added a commit
that referenced
this pull request
Nov 29, 2023
* feat!: promote v3.0.0-alpha.12 to v3.0.0-beta (#187) * feat!: create new structure for isomorphic SDK * feat: add commitlint * feat: add test coverage for client * chore: remove unused variables * feat: sort out default options, tests for helpers * fix: remove postinstall script * chore: updating various bits and constants * feat: laying out the structure of the new library * feat: get requests working * feat: add tests, prerecorded samples, prerecorded requests * feat: working live transcription * feat: rejig the architecture to more closely reflect the documented high-level architecture plan * feat: storing the API domain as a URL object, easier to pass around all clients * fix: missing endpoint from fetch requests to the API * chore: update integration test samples for new usage pattern * feat: types rewriten for all endpoints * feat: add tests for making transcription requests * fix: rename listen test to prerecorded test * chore: reorder some imports for tidiness * fix: rename project API to manage API in the main client * feat: added manage and onprem tests, fixed issues caught by tests * feat: large amount of tests, websocket tests, test server changes, fixes to types * feat: test server and dockerfile * feat: use the mock server's current address to run tests against * feat: fixes to live stream client * fix: fix event types * fix: working live * fix: string should be integer * chore: link to RFC for conforming code * chore: configure prerelease channels * fix: case-sensitive file system issues on mac * feat: marking alpha as a major release version (#166) BREAKING CHANGE: complete rearchitecture of the Node/JavaScript SDK to work in browsers and Node. * feat: export types and enums from main module (#167) * feat: export enums and types from the main module * fix: fix CI workflow not finding coverage report * chore: switch from coveralls to codecov * feat: remove test server code from sdk repo, and fix tests (#170) * feat: remove duplicate example apps (#172) * feat: update workflows so PRs run on all release channel PRs (#175) * chore: ran npm audit * chore: update workflows so CI runs on alpha pulls * feat: remove mimetype requirement from batch requests (rfc #4) (#177) * feat: remove mimetype requirement from local file transcirption (rfc #4) * fix: fix stray array of boolean type (#179) * feat: making schema's possible from request types (#180) * feat: any typing of request options renamed to schema for schema type generation * feat: rename request options types to schema * feat: remove json from this repo * fix: default to application/json when not provided deepgram/audio+video content-type (#181) * fix: blob datatype issues where blob as arraybufferlike had no bytelength (#182) * fix: remove unused package from lock * fix: fixed blob data type issue where blob as arraybufferlike had no bytelength in the browser * fix: remove erroneous browser check * fix: we need node 18 to be blob friendly * fix(types): nested arrays defined as singular tuples incorrectly (#184) * fix(types): nested arrays in LiveTranscriptionEvent (#183) * fix(types): this many array types were defined as singlular tuples - whoops * chore(test): update tests for new mock API url --------- Co-authored-by: Luke Wilson <111262684+ftr-lwilson@users.noreply.github.com> * feat: proxy, CORs, README rewrite (#185) * feat: overhaul client interfaces and scoped option handling * feat: add proxy options for REST calls in the browser, error for browser REST calls without proxy * chore: update code snippets for v-3 (#186) * chore: remove unused packages/vars * feat: add captions as a dependency * feat: small changes to docs * feat: smol changes to README * feat: smol changes to README again * fix(readme): remove version from ESM include example * fix(dependency): fix dependency issue caused by adding the captions library * feat: export client/packages from the entryfile --------- Co-authored-by: Sandra Rodgers <45321563+SandraRodgers@users.noreply.github.com> --------- Co-authored-by: Luke Wilson <111262684+ftr-lwilson@users.noreply.github.com> Co-authored-by: Sandra Rodgers <45321563+SandraRodgers@users.noreply.github.com> * fix: fix dependency issues up and downstream (#188) * fix: find a fix to allow the client to work in either websocket environment (#199) * fix: fixes issues 197 and 198 (#202) * fix: closing the socket too early (#201) * fix: a wild fix for this has appeared (#200) * chore: update examples to match console missions [no ci] (#204) * feat: update websocket to use w3cwebsocket for node/browser/edge worker examples (#205) * feat: tightly couple the api key to the proxy logic, so an api can't mistakenly be made public (#206) --------- Co-authored-by: Luke Wilson <111262684+ftr-lwilson@users.noreply.github.com> Co-authored-by: Sandra Rodgers <45321563+SandraRodgers@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Such is the unique way that Node and JS differ on their WebSocket interfaces, this will attempt one and fall-back to the other if a syntax error is caught. Not great, but it works. I consider this a temporary solution to finding a library that handles WebSockets correctly in an isomorphic library.