Logging throwables

[devinrsmith]

We should prefer to log Throwables via the proper log entry structure, as opposed to just appending as a string. For example:

try {
  someMethod();
} catch (Throwable t) {
  log.error(t).append("Unexpected error").endl(); // 1)
  log.error().append("Unexpected error: ").append(t).endl(); // 2)
}

we should standardize on 1.

We should go through the code and fixup our usage of it.

[rcaudy]

Why do you think that? What if we have more than one throwable? We have many times more code in format 2.

…

On Wed, Mar 3, 2021 at 3:28 PM Devin Smith ***@***.***> wrote: We should prefer to log Throwables via the proper log entry structure, as opposed to just appending as a string. For example: try { someMethod(); } catch (Throwable t) { log.error(t).append("Unexpected error").endl(); // 1) log.error(t).append("Unexpected error: ").append(t); // 2) } we should standardize on 1. We should go through the code and fixup our usage of it. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#108>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABIYLRJH62ERUHVWES5KUH3TB2LVRANCNFSM4YR5M5CA> .

[devinrsmith]

combined = t.addSuppressed(t2)
log.error(combined).append("...").endl()

We should give our logging framework the chance to capture the throwable as an actual throwable, as opposed to a string.