Remove Jetty SNI check#2727
Closed
devinrsmith wants to merge 1 commit intodeephaven:mainfrom
Closed
Conversation
niloc132
reviewed
Aug 29, 2022
| // configured trust stores. An SNI-less Jetty server setup potentially affords proxied deployments a simpler | ||
| // configuration model (essentially, the server does not need to know it is being proxied). | ||
| final boolean sniHostCheck = false; | ||
| httpConfig.addCustomizer(new SecureRequestCustomizer(sniHostCheck)); |
Member
There was a problem hiding this comment.
I believe this will conflict with #2548, which explicitly set it the opposite way.
I would still prefer that we fail "safe" instead of "unsafe" as this is doing, though would be happy to see it fail during the SNI handshake instead of during the HTTP conv as it is doing. If we want to support "unsafe" like this, my opinion is that it should default to safe and require explicit configuration to make it unsafe.
Member
Author
There was a problem hiding this comment.
It's probably worthwhile to follow the same pattern here #2731 for configuring SNI - I'll wait until that has merged until pursuing this further.
Member
Author
|
Superseded by #3843 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.