JS API must support SKIP as an aggregation type#4780
Merged
niloc132 merged 1 commit intodeephaven:mainfrom Nov 16, 2023
Merged
Conversation
mofojed
approved these changes
Nov 16, 2023
Member
mofojed
left a comment
There was a problem hiding this comment.
Looks good, tested with the steps in the ticket #4182 but with this snippet specifying the defaultOperation:
// `temp1` should be the name of your global variable the table is assigned to
var totalsTable = await temp1.getTotalsTable({ defaultOperation: 'Skip', operationMap: { I: ['Sum', 'Count'] } })
console.log('totals columns: ', totalsTable.columns.map(c => c.name))
I do find it slightly odd that our default operation is Sum instead of Skip, but that seems to be consistent with Enterprise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4182