fix: JsPartitionedTable keyColumn and keyColumnTypes ordering#4931
Merged
georgecwan merged 3 commits intodeephaven:mainfrom Dec 19, 2023
Merged
fix: JsPartitionedTable keyColumn and keyColumnTypes ordering#4931georgecwan merged 3 commits intodeephaven:mainfrom
georgecwan merged 3 commits intodeephaven:mainfrom
Conversation
georgecwan
changed the title
georgecwan
added
NoDocumentationNeeded
NoReleaseNotesNeeded
georgecwan
force-pushed
the
fix-partition-keycolumn-order
branch
from
9c8eebc to
414be28
Compare
…artition-keycolumn-order
niloc132
reviewed
Dec 18, 2023
Comment on lines
+104
to
+110
| ColumnDefinition columnDefinition = tableDefinition.getColumnsByName().get(false).get(name); | ||
| int index = 0; | ||
| while (!columns[index].getName().equals(name)) { | ||
| index++; | ||
| } | ||
| keyColumnTypes.add(columnDefinition.getType()); | ||
| keyColumns[keyColumns.length] = columns[index]; |
Member
There was a problem hiding this comment.
No need to loop twice, i think this would do the job too?
Suggested change
| ColumnDefinition columnDefinition = tableDefinition.getColumnsByName().get(false).get(name); | |
| int index = 0; | |
| while (!columns[index].getName().equals(name)) { | |
| index++; | |
| } | |
| keyColumnTypes.add(columnDefinition.getType()); | |
| keyColumns[keyColumns.length] = columns[index]; | |
| ColumnDefinition columnDefinition = tableDefinition.getColumnsByName().get(false).get(name); | |
| keyColumnTypes.add(columnDefinition.getType()); | |
| keyColumns[keyColumns.length] = columns[columnDefinition.getIndex()]; |
georgecwan
force-pushed
the
fix-partition-keycolumn-order
branch
from
2d56f1f to
12f0eec
Compare
niloc132
approved these changes
Dec 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue where JsPartitionedTable returns the keyColumns and keyColumn types in the constituent table's column order which doesn't always match the partitioned table's column order.