fix: LongWrapper comparison through value instead of object#4940
Merged
georgecwan merged 1 commit intodeephaven:mainfrom Dec 13, 2023
Merged
fix: LongWrapper comparison through value instead of object#4940georgecwan merged 1 commit intodeephaven:mainfrom
georgecwan merged 1 commit intodeephaven:mainfrom
Conversation
georgecwan
added
NoDocumentationNeeded
NoReleaseNotesNeeded
niloc132
approved these changes
Dec 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working with tables partitioned by a column of
Longtypes, I was unable to get constituent tables usingLongWrapperobjects obtained from thekeyTablesince there was no override ofLongWrapper'sequalsfunction.This change adds an
equalsandhashCodefunction toLongWrapperso that comparisons are done on theLongvalue field of the objects instead of on the addresses of the objects.