Skip to content

chore: Bump the compiler, runtime, and test runtime version to Java 21#6340

Merged
devinrsmith merged 5 commits intodeephaven:mainfrom
devinrsmith:nightly/java-21-compiler
Nov 12, 2024
Merged

chore: Bump the compiler, runtime, and test runtime version to Java 21#6340
devinrsmith merged 5 commits intodeephaven:mainfrom
devinrsmith:nightly/java-21-compiler

Conversation

@devinrsmith
Copy link
Copy Markdown
Member

Fixes #3997

@devinrsmith devinrsmith added this to the Triage milestone Nov 6, 2024
@devinrsmith devinrsmith self-assigned this Nov 6, 2024
@devinrsmith
Copy link
Copy Markdown
Member Author

This is currently failing nightlies when run with Java 11 or 17, with the error

io.deephaven.lang.completion.ChunkerParserTest

java.lang.UnsupportedClassVersionError: io/deephaven/lang/completion/AllTokenIterableImpl has been compiled by a more recent version of the Java Runtime (class file version 65.0), this version of the Java Runtime only recognizes class file versions up to 61.0

@devinrsmith devinrsmith marked this pull request as ready for review November 7, 2024 18:17
@devinrsmith devinrsmith requested a review from niloc132 November 7, 2024 18:18
@devinrsmith
Copy link
Copy Markdown
Member Author

GroovyCompile has been updated to fix the UnsupportedClassVersionError error.

@devinrsmith
Copy link
Copy Markdown
Member Author

Noted gradle/gradle#18824, gradle/gradle#22449 as links related to --add-exports and --release.

@devinrsmith devinrsmith enabled auto-merge (squash) November 8, 2024 17:58
Copy link
Copy Markdown
Member

@niloc132 niloc132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only reviewing gradle wiring so far, I'm assuming the new tests make sense on their own

Comment thread buildSrc/src/main/groovy/io.deephaven.java-toolchain-conventions.gradle Outdated
Comment thread buildSrc/src/main/groovy/io.deephaven.java-toolchain-conventions.gradle Outdated
@devinrsmith devinrsmith requested a review from niloc132 November 12, 2024 16:22
Copy link
Copy Markdown
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New unit tests LGTM

@devinrsmith devinrsmith merged commit 2df8304 into deephaven:main Nov 12, 2024
@devinrsmith devinrsmith deleted the nightly/java-21-compiler branch November 12, 2024 18:19
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to compile with 17

3 participants