chore: code cleanup, properly scope rpcWrapper context detach#6481
Merged
devinrsmith merged 1 commit intodeephaven:mainfrom Dec 11, 2024
Merged
chore: code cleanup, properly scope rpcWrapper context detach#6481devinrsmith merged 1 commit intodeephaven:mainfrom
devinrsmith merged 1 commit intodeephaven:mainfrom
Conversation
This is a very small code change that correctly scopes a context detach call. Technically this could be considered a "fix", but it very unlikely to matter in practice given that session.getExecutionContext.open() is unlikely to fail.
devinrsmith
added
NoDocumentationNeeded
NoReleaseNotesNeeded
nbauernfeind
approved these changes
Dec 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very small code change that correctly scopes a context detach call. Technically this could be considered a "fix", but it very unlikely to matter in practice given that session.getExecutionContext.open() is unlikely to fail.