fix: Rename internal JS generated grpc/proto packages#6531
Merged
niloc132 merged 2 commits intodeephaven:mainfrom Jan 7, 2025
Merged
fix: Rename internal JS generated grpc/proto packages#6531niloc132 merged 2 commits intodeephaven:mainfrom
niloc132 merged 2 commits intodeephaven:mainfrom
Conversation
niloc132
added
grpc
NoDocumentationNeeded
NoReleaseNotesNeeded
devinrsmith
approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes a small workaround that was added when we first renamed the proto packages, and completes the change in the JS types and their GWT bindings and usages.
Follow-up #6379