feat: DH-18856: Add Median to jsapi Aggregation Options#6700
feat: DH-18856: Add Median to jsapi Aggregation Options#6700dgodinez-dh merged 8 commits intodeephaven:mainfrom
Conversation
There was a problem hiding this comment.
Can you include in the PR description how this was tested?
I assume you have tested via JS API (e.g. from the console on one of the jsapi example pages).
Also there may be additional unit tests to add (@niloc132 ?), and the jsapi/rollup.html page should be updated with the Median aggregation.
Updated the description. But I ended removing Median from the jsapi rollup code. It is not supported in the engine. I am talking to Don about this because I think the UI will need to avoid applying Median to rollup. |
niloc132
left a comment
There was a problem hiding this comment.
Please add a test for this and other supported operations to TotalsTableTestGwt, like HIerarchicalTableTestGwt.testCreateRollupAggTypes(), just to validate that we get results at all.
|
|
||
| return waitForEvent(totals, JsTable.EVENT_UPDATED, update -> { | ||
| ViewportData viewportData = (ViewportData) update.getDetail(); | ||
| assertEquals(2, viewportData.getRows().length); |
There was a problem hiding this comment.
Should probably include checks for the content of the cells in these rows, similar to the above test cases.
There was a problem hiding this comment.
Colin asked for a test similar to HierarchicalTableTestGwt.testCreateRollupAggTypes, which looks like it iterates over all the agg types and checks that they work and send an update. Checking the data might be complicated because we are doing every agg, so the data will be different per agg.
There was a problem hiding this comment.
Added some value checking.
There was a problem hiding this comment.
Data checking in the rollup test doesnt exist either - the intention was just to make sure we could at least read every type, and that no supported agg causes a failure when passing it to the API.
https://deephaven.atlassian.net/browse/DH-18856
Tested using the following branch from
web-client-ui:https://github.com/dgodinez-dh/web-client-ui/tree/dag_MedianAgg
Tested median on numeric, string, and date columns.