fix: DH-20821: make TableDataService extend NamedImplementation#7841
Merged
devinrsmith merged 1 commit intodeephaven:mainfrom Mar 27, 2026
Merged
fix: DH-20821: make TableDataService extend NamedImplementation#7841devinrsmith merged 1 commit intodeephaven:mainfrom
devinrsmith merged 1 commit intodeephaven:mainfrom
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
No docs changes detected for 61afebf |
rcaudy
approved these changes
Mar 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the table-location discovery service API so TableDataService participates in the common NamedImplementation typing pattern used across the locations subsystem.
Changes:
- Make
TableDataServiceextendio.deephaven.util.type.NamedImplementation. - Add the necessary import.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rcaudy
added
NoDocumentationNeeded
NoReleaseNotesNeeded
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
|
recheck |
1 similar comment
Contributor
Author
|
recheck |
deephaven-internal
added a commit
to deephaven/cla
that referenced
this pull request
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.