chore(gradle): bump org.apache.arrow.adbc:adbc-driver-flight-sql from 0.21.0 to 0.23.0#7897
Conversation
|
@dependabot rebase |
1 similar comment
|
@dependabot rebase |
f1889df to
b308887
Compare
No docs changes detected for 7635f42 |
Bumps org.apache.arrow.adbc:adbc-driver-flight-sql from 0.21.0 to 0.23.0. --- updated-dependencies: - dependency-name: org.apache.arrow.adbc:adbc-driver-flight-sql dependency-version: 0.23.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
… of:
Execution failed for task ':extensions-flight-sql:compileAdbcTestJava'.
> Could not resolve all files for configuration ':extensions-flight-sql:adbcTestCompileClasspath'.
> Could not resolve org.bouncycastle:bcutil-jdk18on:[1.80,1.81).
Required by:
project :extensions-flight-sql > org.apache.arrow.adbc:adbc-driver-flight-sql:0.23.0 > org.apache.arrow:flight-sql-jdbc-core:18.3.0 > org.bouncycastle:bcpkix-jdk18on:1.80
> Could not resolve org.bouncycastle:bcutil-jdk18on:[1.80,1.81): Resolution strategy disallows usage of dynamic versions
> Could not resolve org.bouncycastle:bcprov-jdk18on:[1.80,1.81).
Required by:
project :extensions-flight-sql > org.apache.arrow.adbc:adbc-driver-flight-sql:0.23.0 > org.apache.arrow:flight-sql-jdbc-core:18.3.0 > org.bouncycastle:bcpkix-jdk18on:1.80 > org.bouncycastle:bcutil-jdk18on:1.80
> Could not resolve org.bouncycastle:bcprov-jdk18on:[1.80,1.81): Resolution strategy disallows usage of dynamic versions
b308887 to
7635f42
Compare
|
We can pin the bouncy castle version to get the ADBC test configuration to compile by preventing the dependency ranges that are otherwise published in the bouncy castle artifacts from being used. There is a comment on this issue (bcgit/bc-java#2087) that claims we should not need to do that if gradle has a secure XML parser. |
| // The BouncyCastle provider must be pinned to a particular version, because otherwise we end up with a dynamic | ||
| // range "org.bouncycastle:bcprov-jdk18on:[1.80,1.81)" from org.apache.arrow:flight-sql-jdbc-core:18.3.0 which is | ||
| // not permitted by our build. | ||
| adbcTestImplementation libs.bcprov.jdk18on | ||
| adbcTestImplementation libs.bcutil.jdk18on | ||
| adbcTestImplementation libs.bcpkix.jdk18on |
There was a problem hiding this comment.
I would be wary of doing this; it seems like later releases of BouncyCastle have started using specific versions instead of ranges. If anything, I would want to see us use a dependency constraints block, possibly just against a newer version of BouncyCastle.
| @@ -1,12 +1,14 @@ | |||
| [versions] | |||
| adbc = "0.21.0" | |||
| adbc = "0.23.0" | |||
There was a problem hiding this comment.
I would add a note "on bump, check if dependency constraint workaround can be removed".
Bumps org.apache.arrow.adbc:adbc-driver-flight-sql from 0.21.0 to 0.23.0.