feat: DH-22379: add getColumnSource from ColumnDefinition#7932
Merged
devinrsmith merged 2 commits intodeephaven:mainfrom Apr 25, 2026
Merged
Conversation
devinrsmith
added
NoDocumentationNeeded
NoReleaseNotesNeeded
Contributor
No docs changes detected for cafa2a9 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a Table.getColumnSource(ColumnDefinition) overload to simplify retrieving typed ColumnSources directly from a ColumnDefinition, and updates several internal call sites to use the new overload.
Changes:
- Add
Table.getColumnSource(ColumnDefinition)API and aTableDefinition.checkHasColumn(ColumnDefinition)convenience overload. - Implement the new
getColumnSource(ColumnDefinition)inTableDefaultsby delegating to the existing typed overload. - Refactor stream + hierarchical table implementations to call
getColumnSource(cd)instead of plumbing name/type/componentType manually.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| engine/table/src/main/java/io/deephaven/stream/TableStreamPublisherImpl.java | Switches column source retrieval to the new getColumnSource(ColumnDefinition) overload. |
| engine/table/src/main/java/io/deephaven/engine/table/impl/hierarchical/TreeTableImpl.java | Uses the new overload when building chunk source arrays. |
| engine/table/src/main/java/io/deephaven/engine/table/impl/hierarchical/RollupTableImpl.java | Uses the new overload for aggregated/constituent chunk sources. |
| engine/table/src/main/java/io/deephaven/engine/table/impl/TableDefaults.java | Adds the default implementation for getColumnSource(ColumnDefinition). |
| engine/api/src/main/java/io/deephaven/engine/table/TableDefinition.java | Adds checkHasColumn(ColumnDefinition) convenience method. |
| engine/api/src/main/java/io/deephaven/engine/table/Table.java | Adds the new getColumnSource(ColumnDefinition) API and updates related Javadoc. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cpwright
approved these changes
Apr 23, 2026
rcaudy
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.