Skip to content

fix: DH-22298: Don't send Jetty version in http responses by default #7935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
niloc132 wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −0
Open

fix: DH-22298: Don't send Jetty version in http responses by default #7935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db1a8d9
Prop for vers, disable jetty vers
niloc132 Apr 24, 2026
4afe965
Back out the server vers
niloc132 Apr 24, 2026
df140b5
spotless
niloc132 Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions server/jetty-11/src/main/java/io/deephaven/server/jetty11/JettyBackedGrpcServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,8 @@ public int getPort() {
private static ServerConnector createConnector(Server server, JettyConfig config) {
// https://www.eclipse.org/jetty/documentation/jetty-11/programming-guide/index.html#pg-server-http-connector-protocol-http2-tls
final HttpConfiguration httpConfig = new HttpConfiguration();
httpConfig.setSendServerVersion(
Configuration.getInstance().getBooleanWithDefault("http.send.server.version", false));
httpConfig.addCustomizer(new ForwardedRequestCustomizer());
httpConfig.addCustomizer(new AllowedHttpMethodsCustomizer(config.allowedHttpMethods()));
if (!config.extraHeaders().isEmpty()) {
Expand Down
2 changes: 2 additions & 0 deletions server/jetty/src/main/java/io/deephaven/server/jetty/JettyBackedGrpcServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,8 @@ public int getPort() {
private static ServerConnector createConnector(Server server, JettyConfig config) {
// https://www.eclipse.org/jetty/documentation/jetty-11/programming-guide/index.html#pg-server-http-connector-protocol-http2-tls
final HttpConfiguration httpConfig = new HttpConfiguration();
httpConfig.setSendServerVersion(
Configuration.getInstance().getBooleanWithDefault("http.send.server.version", false));
httpConfig.addCustomizer(new ForwardedRequestCustomizer());
httpConfig.addCustomizer(new AllowedHttpMethodsCustomizer(config.allowedHttpMethods()));
if (!config.extraHeaders().isEmpty()) {
Expand Down
Loading
⚡