fix: DH-21978: WorkerHeapSize column is Incorrect.#7937
Merged
cpwright merged 2 commits intodeephaven:mainfrom Apr 27, 2026
Merged
fix: DH-21978: WorkerHeapSize column is Incorrect.#7937cpwright merged 2 commits intodeephaven:mainfrom
cpwright merged 2 commits intodeephaven:mainfrom
Conversation
This is the Core half of the fix, the performance queries are assuming the heap size we are analyzing is the same size as the current worker which is not a generally valid assumption. The Core+ half of the fix is to write the heap size down to permanent logs for later analysis.
cpwright
added
NoDocumentationNeeded
ReleaseNotesNeeded
Contributor
No docs changes detected for 238690b |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes incorrect WorkerHeapSize handling in performance queries by stopping the assumption that the heap size being analyzed matches the current worker, and instead sourcing heap size from the log stream itself.
Changes:
- Removed injection of
WorkerHeapSizebased on the current worker fromPerformanceQueriesGeneral. - Added a
WorkerHeapSizecolumn to query/update performance stream publishers and populated it once per publisher from the JVM max heap. - Introduced a small
HeapSizeutility to centralize max-heap retrieval for performance logging.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| extensions/performance/src/main/java/io/deephaven/engine/table/impl/util/PerformanceQueriesGeneral.java | Stops injecting current-worker heap size into performance query views; relies on logged heap size instead. |
| engine/table/src/main/java/io/deephaven/engine/table/impl/util/QueryPerformanceStreamPublisher.java | Extends query performance stream schema to include WorkerHeapSize and publishes the value. |
| engine/table/src/main/java/io/deephaven/engine/table/impl/util/QueryOperationPerformanceStreamPublisher.java | Extends operation performance stream schema to include WorkerHeapSize and publishes the value. |
| engine/table/src/main/java/io/deephaven/engine/table/impl/util/HeapSize.java | New helper for retrieving JVM max heap size for logging. |
| engine/table/src/main/java/io/deephaven/engine/table/impl/perf/UpdatePerformanceStreamPublisher.java | Extends update performance stream schema to include WorkerHeapSize and publishes the value. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
devinrsmith
reviewed
Apr 24, 2026
Member
devinrsmith
left a comment
devinrsmith
left a comment
There was a problem hiding this comment.
Technically, maximum heap size can change over time. I wonder if we want to try and capture this possibility?
The maximum amount of memory may change over time if defined.
devinrsmith
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the Core half of the fix, the performance queries are assuming the heap size we are analyzing is the same size as the current worker which is not a generally valid assumption. The Core+ half of the fix is to write the heap size down to permanent logs for later analysis.