fix: DH-22381: Correct guard logic in adaptEmOptions for EM aggregations#7938
Merged
cpwright merged 3 commits intodeephaven:mainfrom Apr 28, 2026
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
No docs changes detected for 34d0561 |
lbooker42
added
NoDocumentationNeeded
ReleaseNotesNeeded
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the server-side guard logic when adapting UpdateByEmOptions for exponential moving (EM*) update-by operations, ensuring only explicitly specified on_null_value / on_nan_value behaviors are applied and avoiding passing NOT_SPECIFIED into adaptBadDataBehavior.
Changes:
- Correct
adaptEmOptions()to guard onon_null_value/on_nan_valuebeing specified (!= NOT_SPECIFIED) and to check the correct field for the null guard. - Add a new gRPC test class intended to cover combinations of EM options for EMA and EmStd operations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
server/src/main/java/io/deephaven/server/table/ops/UpdateByGrpcImpl.java |
Fixes the guard logic in adaptEmOptions() so OperationControl is only populated when behaviors are actually specified. |
server/src/test/java/io/deephaven/server/table/ops/UpdateByEmOptionsGrpcTest.java |
Adds tests around EM option combinations for EMA / EmStd, aiming to prevent regressions in option adaptation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
cpwright
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.