feat: Remove UI theme from PlotlyExpressChartModel#251
Merged
mattrunyon merged 3 commits intodeephaven:mainfrom Feb 16, 2024
Merged
feat: Remove UI theme from PlotlyExpressChartModel#251mattrunyon merged 3 commits intodeephaven:mainfrom
mattrunyon merged 3 commits intodeephaven:mainfrom
Conversation
mattrunyon
force-pushed
the
plotly-express-theme
branch
from
724699f to
5150680
Compare
mattrunyon
force-pushed
the
plotly-express-theme
branch
from
5150680 to
f5bbfa5
Compare
bmingles
added a commit
to deephaven/web-client-ui
that referenced
this pull request
Feb 13, 2024
This PR - Move theme colors down to `layout.template.layout` so that they are used as defaults. Some of the theme colors had to be set in `layout.template.data` for specific trace types - Chart component now responds to ChartTheme context changes (this should enable chart theme switching, but it depends on some follow up plugins repo work to complete it). **Testing** For now, we should just make sure charts behave as they did before. Not all charts will update in response to a theme change, but re-running queries should show the theme change. I have tested this and have not seen any changes to existing behavior introduced by this PR Once the following plugins repo PRs have merged, the chart should fully respond to theme changes: deephaven/deephaven-plugins#243 deephaven/deephaven-plugins#251 resolves #1728 BREAKING CHANGE: - Renamed `ColorUtils.getColorwayFromTheme` to `normalizeColorway` - Removed `chartTheme` arg from functions in `ChartUtils`, `ChartModelFactory` and `FigureChartModel` in @deephaven/chart
mattrunyon
force-pushed
the
plotly-express-theme
branch
from
f5bbfa5 to
63adfc5
Compare
bmingles
approved these changes
Feb 16, 2024
Contributor
bmingles
left a comment
bmingles
left a comment
There was a problem hiding this comment.
Changes look good. Tested locally and verified theme changing works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #216
PlotlyExpressChartModel should just remove the colors on the traces instead of setting them to the UI theme. The UI theme then gets applied via the template colorway